Stepper: avoid division by zero #4318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for inputs of 0 and set it to 1 as the minimum Signed-off-by: Kenneth Lim <kennethlimcp@gmail.com>
|
This PR touches on the same library as #4257, and IIRC there was some change to prevent zero division there as well. Since merging this one probably complicates merging that one, perhaps this commit could be included in that PR, or at least merged after it. Looking at the actual commit, I'm wondering what the motivation for it is? Passing a 0 speed or number of steps doesn't make sense, so it's not a valid input. On AVR, I think division by zero doesn't actually trigger any exception, so no really special handling is needed, but perhaps that's different on the Particle devices (or arm devices in general)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for inputs of 0 and set it to 1 as the minimum
Was added here for Particle devices: https://github.com/kennethlimcp/spark-stepper/pull/2
Signed-off-by: Kenneth Lim kennethlimcp@gmail.com